Skip to content

Do not ICE on HIR based WF check when involving lifetimes #87811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2021
Merged

Do not ICE on HIR based WF check when involving lifetimes #87811

merged 1 commit into from
Aug 11, 2021

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Aug 6, 2021

Fix #87549.

@estebank estebank added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2021
@rust-highfive
Copy link
Contributor

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2021
oli-obk
oli-obk reviewed Aug 6, 2021
View reviewed changes
oli-obk
oli-obk reviewed Aug 6, 2021
View reviewed changes
@estebank estebank force-pushed the issue-87549 branch 4 times, most recently from aeef0d8 to 58a7139 Compare August 6, 2021 15:55
Aaron1011
Aaron1011 reviewed Aug 6, 2021
View reviewed changes
@oli-obk
Copy link
Contributor

oli-obk commented Aug 9, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 9, 2021

📌 Commit f93cbed has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2021
@bors
Copy link
Collaborator

bors commented Aug 9, 2021

⌛ Testing commit f93cbed with merge 7fd57c7bda1ff4c6c037e3a5597faa9c59e68a67...

@Aaron1011 Aaron1011 mentioned this pull request Aug 9, 2021
Closed
@bors
Copy link
Collaborator

bors commented Aug 9, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2021
@Aaron1011
Copy link
Contributor

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 10, 2021
@JohnTitor
Rollup merge of rust-lang#87811 - estebank:issue-87549, r=oli-obk
5709f22 
Do not ICE on HIR based WF check when involving lifetimes

Fix rust-lang#87549.
@JohnTitor JohnTitor mentioned this pull request Aug 10, 2021
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 10, 2021
@JohnTitor
Rollup merge of rust-lang#87811 - estebank:issue-87549, r=oli-obk
fe34bc5 
Do not ICE on HIR based WF check when involving lifetimes

Fix rust-lang#87549.
@JohnTitor JohnTitor mentioned this pull request Aug 10, 2021
Closed
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@estebank
Copy link
Contributor Author

@bors retry

@JohnTitor JohnTitor mentioned this pull request Aug 10, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 10, 2021
@bors
Auto merge of rust-lang#87923 - JohnTitor:rollup-id54fyz, r=JohnTitor
e8e1b32 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#86840 (Constify implementations of `(Try)From` for int types)
 - rust-lang#87582 (Implement `Printer` for `&mut SymbolPrinter`)
 - rust-lang#87636 (Added the `Option::unzip()` method)
 - rust-lang#87700 (Expand explanation of E0530)
 - rust-lang#87811 (Do not ICE on HIR based WF check when involving lifetimes)
 - rust-lang#87848 (removed references to parent/child from std::thread documentation)
 - rust-lang#87854 (correctly handle enum variants in `opt_const_param_of`)
 - rust-lang#87861 (Fix heading colours in Ayu theme)
 - rust-lang#87865 (Clarify terms in rustdoc book)
 - rust-lang#87876 (add `windows` count test)
 - rust-lang#87880 (Remove duplicate trait bounds in `rustc_data_structures::graph`)
 - rust-lang#87881 (Proper table row formatting in platform support)
 - rust-lang#87889 (Use smaller spans when suggesting method call disambiguation)
 - rust-lang#87895 (typeck: don't suggest inaccessible fields in struct literals and suggest ignoring inaccessible fields in struct patterns)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bcef40e into rust-lang:master Aug 11, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 11, 2021
@JohnTitor JohnTitor mentioned this pull request Aug 11, 2021
Merged
@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 12, 2021
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 27, 2021
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.56.0, 1.55.0 Aug 27, 2021
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Aug 27, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 28, 2021
@bors
Auto merge of rust-lang#88400 - Mark-Simulacrum:beta-next, r=Mark-Sim…
27e88d3 
…ulacrum

[beta] backports

This PR rolls up a number of beta backports:

* Split critical edge targeting the start block rust-lang#88124
* Make BuildHasher object safe rust-lang#88031
* Fix Windows Command::env("PATH") rust-lang#87863
* Do not ICE on HIR based WF check when involving lifetimes rust-lang#87811
* Update compiler_builtins to fix i128 shift/mul on thumbv6m rust-lang#87633
@estebank estebank deleted the issue-87549 branch November 9, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

+1 more reviewer

@Aaron1011 Aaron1011 Aaron1011 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@oli-obk oli-obk

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.

Type checking for this incorrect impl trait panics with incremental compilation
9 participants
@estebank @rust-highfive @oli-obk @bors @Aaron1011 @rust-log-analyzer @apiraino @Mark-Simulacrum @rustbot